-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic auth: fix timing oracle #2609
basic auth: fix timing oracle #2609
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2609 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 41 41
Lines 1989 1989
=======================================
Hits 1962 1962
Misses 15 15
Partials 12 12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Revert "Adding ppc64le architecture support on travis-ci (gin-gonic#2538)" (gin-gonic#2602) * test: fixed the TestUnixSocket test on windows (gin-gonic#2595) Co-authored-by: thinkerou <thinkerou@gmail.com> * gin mode unknown: show available mode (gin-gonic#2567) Co-authored-by: thinkerou <thinkerou@gmail.com> * fix error gin support min Go version (gin-gonic#2584) Co-authored-by: thinkerou <thinkerou@gmail.com> * Fixes to the graceful shutdown example (gin-gonic#2552) * Change error comparison to use errors.Is() and add a line of whitespace before the if statement on graceful shutdown * Change from log.Fatalf to log.Printf to ensure the graceful shutdown actually works Co-authored-by: J. J. Bigorra <josep@prowarehouse.nl> Co-authored-by: thinkerou <thinkerou@gmail.com> * basic auth: fix timing oracle (gin-gonic#2609) Co-authored-by: thinkerou <thinkerou@gmail.com> * chore: Deleted spaces (gin-gonic#2622) * Remove the tedious named return value (gin-gonic#2620) Co-authored-by: thinkerou <thinkerou@gmail.com> Co-authored-by: thinkerou <thinkerou@gmail.com> Co-authored-by: Jeff <laojianzi1994@gmail.com> Co-authored-by: Rubi <14269809+codenoid@users.noreply.github.com> Co-authored-by: Qt <golang.chen@gmail.com> Co-authored-by: Josep Jesus Bigorra Algaba <42377845+averageflow@users.noreply.github.com> Co-authored-by: J. J. Bigorra <josep@prowarehouse.nl> Co-authored-by: Snawoot <vladislav-ex-github@vm-0.com> Co-authored-by: Alexander Melentyev <55826637+alexander-melentyev@users.noreply.github.com> Co-authored-by: Andy Pan <panjf2000@gmail.com>
Fix #2226
I've read discussion in #2226, but there are few reasons to consider on behalf of merge of this PR: