Implement some ELF/Mach-O relocations #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
Oct 23, 2018
src/traits.rs
Outdated
| @@ -111,6 +111,12 @@ pub trait ObjectSegment<'data> { | |||
|
|
|||
| /// A section defined in an object file. | |||
| pub trait ObjectSection<'data> { | |||
| /// An iterator over the reloctions for a section. | |||
This will be useful for when we want both uncompressed data and relocations for a named section.
Merged
mcbegamerxx954
pushed a commit
to mcbegamerxx954/object
that referenced
this pull request
Jun 15, 2024
Implement some ELF/Mach-O relocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns the relocations only. It is up to the caller to apply them.
These are the minimum ELF relocations that I need to dwarfdump an object file. The Mach-O relocations weren't needed for that (because it has implicit addends), but it helps generalize the API.
I didn't look into PE relocations (it'll only be dynamic linking relocations?), and we don't support COFF yet.
WASM is probably going to be rather different, but I didn't look into it much. It'll be okay to add WASM specific entries to
RelocationKind.Note: there's an initial commit with rustfmt changes.
Fixes #4