Properly handle DW_CFA_GNU_args_size #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple, really. It stores the value of DW_CFA_GNU_args_size inside the UnwindTableRow. Defaults to 0.
As we talked in #130 unwinders should add this value to SP when setting IP.
CC @main--
So indeed, i686-pc-windows-gnu generates those. I've been unable to make any other target generate them, even with custom target changing the data-layout. So testing this is a bit painful since there's no 32-bit x86 backend to unwind-rs (I might work on this soon though!)