Reorder parsing of type qualifiers to match the spec. #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec says that the
qualified-type
production (withintype
) is parsed second only to thebuiltin-type
production. Thequalified-type
production is ambiguous with later productions (in particular with the "Ul" insideclass-enum-type
) so the order does matter. This reorders things for "Ul" and brings along the other parts of thequalified-type
production.To preserve the existing behavior for
function-type
, rather than attempt to pass down a leadingCV-qualifiers
we simply skip them if the tail remaining indicates afunction-type
production is imminent.This is the root cause of @Swatinem's issue, though perhaps some defense in depth that limits runaway growth of substitution tables is still wise.