Fixes #8 #28
Closed
Fixes #8 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gillesdemey
changed the title
spacecat
reviewed
Apr 25, 2018
| @@ -67,6 +76,7 @@ exports.start = function (options) { | |||
| } | |||
| cp = spawn(cmd, cmdArgs, cmdOptions) | |||
| var rec = cp.stdout | |||
| rec.setEncoding('binary'); | |||
There was a problem hiding this comment.
This gave me an encoding error. I removed this line and it worked for me.
|
Closing in favor of #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added addional args to work with sox. (may no longer work with rec - needs to be testet)
made use of the silence-extention optional
added option to return raw pcm-data instead of wav
changed stdout-encoding to binary (pretty sure it is utf-8 by default)