Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move yaml import to be a local import within init_logging_impl - 33 #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move yaml import to be a local import within init_logging_impl - 33 #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions puma/logging/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
from pathlib import Path
from typing import Any, Dict, Iterable, List, Optional, Set, Union, cast, no_type_check

import yaml

from puma.buffer.implementation.managed_queues import ManagedProcessQueue
from puma.helpers.class_name import get_class_fully_qualified_name, get_fully_qualified_name
from puma.helpers.string import safe_str
Expand Down Expand Up @@ -276,9 +274,11 @@ def print_logging_mechanics_for_logger(cls, logger: logging.Logger) -> None:

@classmethod
def init_logging_impl(cls, config_filename: str) -> None:
from yaml import safe_load

config_path = cls._find_config_file(config_filename)
with config_path.open('rt') as f:
config = yaml.safe_load(f.read())
config = safe_load(f.read())
cls._apply_dictionary_config(config)

@classmethod
Expand Down