Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter event created by other users #77

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

lyind
Copy link
Contributor

@lyind lyind commented Jun 22, 2023

Resolves giantswarm/giantswarm#26776

Summary

Don't return TimeOffs for events created by other users than the owner of the personal calendar.

That means that such events won't be synced with Personio.

This should effectively fulfill the user-case described in giantswarm/giantswarm#26776, even though it is not exactly the implementation initially described.

@lyind lyind requested a review from MarcelMue June 22, 2023 22:52
@lyind lyind requested a review from a team as a code owner June 22, 2023 22:52
Copy link
Contributor

@MarcelMue MarcelMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this and see if false positives decrease

@lyind lyind merged commit 963e3c2 into main Jun 23, 2023
5 checks passed
@lyind lyind deleted the filter-other-calendars branch June 23, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants