Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snackbar poor contrast with dark theme #315

Closed
ghusta opened this issue Jan 10, 2023 · 3 comments
Closed

Snackbar poor contrast with dark theme #315

ghusta opened this issue Jan 10, 2023 · 3 comments
Labels
Milestone

Comments

@ghusta ghusta added the ui/ux label Jan 10, 2023
@ghusta ghusta added this to the 1.13.0 milestone Jan 10, 2023
@ghusta
Copy link
Owner Author

ghusta commented Jan 22, 2023

With Widget.Design.Snackbar style :

<item name="backgroundTint">var</item>

With @style/Widget.MaterialComponents.Snackbar style :

<item name="backgroundColor">var</item> ???

@ghusta
Copy link
Owner Author

ghusta commented Feb 13, 2023

Item colorPrimaryDark legacy -> see also material-components/material-components-android@f428f20

@ghusta ghusta modified the milestones: 1.13.0, 1.14.0 Feb 15, 2023
ghusta added a commit that referenced this issue Mar 8, 2023
@ghusta ghusta closed this as completed Mar 8, 2023
@ghusta
Copy link
Owner Author

ghusta commented Mar 22, 2023

See also :

Combining light and dark themes

When a light surface is needed in a dark theme, light coloring can be used on select component surfaces to preserve hierarchy.

For example, a dark theme snackbar can display a light surface to help it stand out. To do so, it can apply the light theme's Surface and On Surface colors.

snackbar_dark_md2

The snackbar uses a light surface in a dark theme to help it stand out.

  1. On Surface: #FFFFFF
  2. Surface: #121212
  3. Primary Variant: #3700B3

Source : https://m2.material.io/design/color/dark-theme.html#custom-application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant