Gtk: change title prompt #5905
Open
Gtk: change title prompt #5905
+127
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hasn't set a title before
jcollie
requested changes
Feb 20, 2025
src/apprt/gtk/App.zig
Outdated
| @@ -1809,6 +1819,13 @@ fn initContextMenu(self: *App) void { | |||
| c.g_menu_append(section, "Split Down", "win.split_down"); | |||
| } | |||
|
|
|||
| { | |||
There was a problem hiding this comment.
Any menu changes should be deferred until #5781 lands.
There was a problem hiding this comment.
I removed the menu entry definition from the code for now.
- use blueprint for the dialog content - use zig-gobject bindings - make the enum values lowercase
maciekbartczak
commented
Feb 21, 2025
Comment on lines
+1025
to
+1026
| dialog.addResponse("cancel", "Cancel"); | ||
| dialog.addResponse("ok", "OK"); |
There was a problem hiding this comment.
This could possibly be done from the .blp since there is a responses property on the AlertDialog, however I could not get this to work. Also there are no examples to be found of how do define the responses from the blueprint, so I'm just leaving the definitions in the code right now.
- remove the menu entry defined in code
- set the current title in the input buffer - fix formatting
jcollie
reviewed
Feb 21, 2025
- remove unnecessary @ptrCast - set the default focus to the text entry field
|
Two things that I modified from the original dialog version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the title change functionality for the GTK app and closes #5769
Demo:
rename_terminal.mp4
For now I came up with a basic UI that i believe is sufficient, but I'm open to feedback and happy to iterate on it further.
#5769 (comment) - Regarding Mitchell's comment I checked Gnome Console and I could not find a similar feature.