Fix tilde path handling in terminal links #5813
Conversation
- Improve path handling in Surface.zig to correctly expand standalone tilde (~) to $HOME - Update URL regex in config/url.zig This change ensures that: - Standalone tilde (~) is clickable and opens the home directory - Paths starting with ~/ correctly expand to the home directory - Other path patterns remain unchanged Add test cases for tilde path handling in url.zig
Pym
changed the title
There was a problem hiding this comment.
There's a lot of repeated logic we should stop doing since it is very platform-specific. i.e. the HOME env var is not correct to use even on macOS (if its not set) nor Windows when we get there. Additionally, std.posix won't be available on Windows so that's no good either.
I'm also curious how this interacts with OSC8 hyperlinks and how other terminals handle this scenario. Can any terminal program sending tilde-paths via OSC8 and have it open? (I can't even recall if you can set file URLs with OSC8 to be honest it's been awhile since I looked at that spec).
|
|
||
| // Handle paths starting with ~ | ||
| if (str.len > 0 and str[0] == '~') { | ||
| const home = std.posix.getenv("HOME") orelse ""; |
There was a problem hiding this comment.
We should be using internal_os.expandHome instead of repeating this logic everywhere.
mitchellh
added
the
feedback-requested
|
Thanks @mitchellh for this detailed feedback. Indeed, I am new to Zig and I went a bit too fast in my implementation, without taking into account the cross-platform aspects and the reuse of existing code. I will take the time to study the OSC8 specification in more detail. I will come back with an improved version of this PR! |
|
Appreciate it. Please reopen this PR when you do so or open a new one, I'd rather not a have a stale PR dangling. Thank you! |
This PR improves the handling of tilde (
~) in clickable paths within the terminal, making it more consistent with standard terminal behavior.Related to issue #1972 and PR #5801
Changes
Core Functionality
Surface.zigto properly expand tilde pathsconfig/url.zigto recognize standalone tilderenderer/link.zigfor better maintainabilityTest Coverage
Added comprehensive test cases in
url.zigto verify:~) detection and expansion~/path) handlingcd ~ to go home)Impact
These changes ensure:
~opens the home directory~/correctly expand to the full home directory path