macos: add titled-visible-menu option to macos-non-native-fullscreen #5397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sassanh
force-pushed
the
titled-visible-menu-fullscreen
branch
from
d5c3dc5 to
91b4920
Compare
|
This is how it looks: |
sassanh
force-pushed
the
titled-visible-menu-fullscreen
branch
from
91b4920 to
abd0fd9
Compare
mitchellh
requested changes
Jan 29, 2025
sassanh
force-pushed
the
titled-visible-menu-fullscreen
branch
from
abd0fd9 to
899e419
Compare
@mitchellh Thanks! I applied the changes. |
sassanh
force-pushed
the
titled-visible-menu-fullscreen
branch
from
899e419 to
bea12a2
Compare
Non-native fullscreen has certain limitations at the moment regarding being truly fullscreen (taking all screen surface) and losing no functionality when activated. Currently, tab functionality is lost when non-native fullscreen is activated. This commit introduces the `titled-visible-menu` mode for macOS non-native fullscreen. Like `visible-menu` mode, it hides the dock and uses its surface, leaving the menubar visible. This mode makes full use of the screen (except for the menubar) while retaining the tabbar’s functionality. While a truly fullscreen non-native mode without feature loss is ideal, this implementation provides a functional alternative in the meantime.
sassanh
force-pushed
the
titled-visible-menu-fullscreen
branch
from
bea12a2 to
42a0967
Compare
|
@mitchellh Kindly review it again when you got the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-native fullscreen has certain limitations at the moment regarding being truly fullscreen (taking all screen surface) and losing no functionality when activated. Currently, tab functionality is lost when non-native fullscreen is activated.
This commit introduces the
titled-visible-menumode for macOS non-native fullscreen. Likevisible-menumode, it hides the dock and uses its surface, leaving the menubar visible. This mode makes full use of the screen (except for the menubar) while retaining the tabbar’s functionality.While a truly fullscreen non-native mode without feature loss is ideal, this implementation provides a functional alternative in the meantime.