[macOS] feat: Support Tabs in Quick Terminal #5370
Conversation
| animateOut() | ||
| } | ||
|
|
||
| @IBAction func newTab(_ sender: Any?) { |
There was a problem hiding this comment.
📝
This is never called because the window is an NSPanel without a title bar. So, I removed it and added the observer for Ghostty.Notification.ghosttyNewTab.
| @@ -329,6 +329,9 @@ class TerminalManager { | |||
| guard let surfaceView = notification.object as? Ghostty.SurfaceView else { return } | |||
| guard let window = surfaceView.window else { return } | |||
|
|
|||
| // return if window is not in our managed windows | |||
| guard windows.contains(where: { $0.controller.window == window }) else { return } | |||
There was a problem hiding this comment.
📝
If the window is not managed by the TerminalManager (which is usually the case when it is managed by the QuickTerminalManager), the process will be aborted. Without this, a new TerminalWindow would be created.
…e left (like native tabs)
sohsatoh
force-pushed
the
feat/quickterm-with-tab
branch
from
be37844 to
98a0e07
Compare
|
Just noting I'm going to wait to review this until after 1.1. |
|
I've swapped to this forked version this were a required features for me to use Ghostty. I've noticed two things that differs from the built in tabs.
|
|
@sohsatoh I noticed a really huge bug, if you have splits and you open a new tab, all the splits disappear. So, you can't switch tabs without all splits disappearing |
|
@mitchellh this issue is a deal breaker for many macOS users since we are trying to migrate from iTerm, I tested this and it looks like a really good implementation IMO, if the bug I mentioned earlier is fixed of course. I also wanted to ask you something because I'm not sure about your policies. May I? Okay, so, I use quick term in center position and it's very annoying that every time you spawn the terminal, its position gets reset which isn't really convenient after I toggle it. I rewrote the code so it "remembers" Terminal position even after you toggle it. So, my question is, can I create an issue for it or maybe a merge request or maybe you don't want this feature? |
Oh, thanks. I haven't noticed that as I don't use split term. I will try to fix it in this weekend (hopefully).
Just to clarify, is this question related to my PR? If not, I believe it would be best to follow the guidelines in CONTRIBUTING.md. Of course, we are happy to answer questions or provide/take advice about the implementation, but please keep in mind that a PR is not an open forum for general discussions. |
|
@sohsatoh I also noticed that that |
related to #2329
This pull request implements a tab management feature for the Quick Terminal in the Ghostty for macOS.
macOS does not support tab management without a title bar. Therefore, this PR implements non-native tabs instead of using macOS native tabs.
Changes
Appearance
window-theme = dark
window-theme = light
Notes
The implementation is designed to work similarly to native tabs and to behave consistently with the (standard) terminal windows in Ghostty. However, there may be some aspects I might have overlooked. Please feel free to make any necessary fixes to the implementation as needed.