bash: handle additional command arguments #5319
Merged
+32
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A '-' or '--' argument signals the end of bash's own options. All remaining arguments are treated as filenames and arguments. We shouldn't perform any additional argument processing once we see this signal. We could also assume a non-interactive shell session in this case unless the '-i' (interactive) shell option has been explicitly specified, but let's wait on that until we know that doing so would solve a real user problem (and avoid any false negatives).
jparise
commented
Jan 23, 2025
| @@ -203,8 +203,6 @@ test "setup features" { | |||
| /// our script's responsibility (along with disabling POSIX | |||
| /// mode). | |||
| /// | |||
| /// This approach requires bash version 4 or later. | |||
There was a problem hiding this comment.
This was never quite true. The problem was with Apple's patched version of bash 3.2 (#2966).
jparise
commented
Jan 23, 2025
| while (iter.next()) |remaining_arg| { | ||
| try args.append(remaining_arg); | ||
| } | ||
| break; |
There was a problem hiding this comment.
The loop will naturally terminate because we entirely consume the iterator above, but I made this explicit with the break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A '-' or '--' argument signals the end of bash's own options. All remaining arguments are treated as filenames and arguments. We shouldn't perform any additional argument processing once we see this signal.
We could also assume a non-interactive shell session in this case unless the '-i' (interactive) shell option has been explicitly specified, but let's wait on that until we know that doing so would solve a real user problem (and avoid any false negatives).