Make Ghostty aware of left/right modifier keys #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #218
Related to #242
This makes the core Ghostty API aware of left/right modifier keys and able to distinguish between them. Only macOS is able to distinguish, every other platform marks "both" as being pressed.
On macOS, this also allows keybindings to target a specific directional modifier. For example,
keybind = left_shift+w=close_windowis now valid. On platforms that don't support directional modifiers, this is equivalent to just usingshift.This issue is primarily on the way so that we can enable a
option_as_altconfiguration for macOS as noted in #218 and allow people to choose only one option key to use as alt.There is still a long road to making keyboard layout handling not garbage. This is just a stone in the path...