OSC8 Hyperlink Support #1928
Merged
OSC8 Hyperlink Support #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables these funcs to access memory offsets that may be present in set items, which is possible since the set itself is in an offset-based structure.
|
GTK: URL overlay moves when mouse cursor moves over it, but URL under the mouse cursor is not detected. Screencast.from.2024-07-07.13-36-37.webm |
Thanks, fixed. |
jparise
reviewed
Jul 7, 2024
| explicit: Offset(u8).Slice, | ||
|
|
||
| /// No ID was provided so we auto-generate the ID based on an | ||
| /// incrementing counter attached to the screen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1197
This adds support for OSC8 Hyperlinks.
This PR is primarily focused on the core functionality. The links behave almost identically to #968: i.e. the underline only shows up on hover + ctrl/command. I think we can improve this behavior for OSC8 specifically in the future because the nature of OSC8 is that the TUI program wants it to be a link.
Since the URL is not obvious on a hyperlink, this PR also modifies the GUI to add a visual element to show the hovered URL. This behavior has been added to normal regex URLs too.
CleanShot.2024-07-07.at.09.46.01.2.mp4
cc @rockorager @gpanders who were particularly interested in this.