cmd: use github.Client for release command

Also add a note about why `--auth-user` is unnecessary/misleading for
the release command.

Fixes github-release#106.

.github/workflows/ci.yml

@@ -19,5 +19,5 @@ jobs:
     - run: echo "::set-env name=GOPATH::$GITHUB_WORKSPACE"
     - run: echo "::set-env name=PATH::$GITHUB_WORKSPACE/bin:$PATH"
     - name: Run tests
-      run: make test
+      run: make lint test
       working-directory: './src/github.com/github-release/github-release'

Makefile

@@ -91,6 +91,9 @@ clean:
 	rm $(EXECUTABLE) || true
 	rm -rf bin/
 
+lint:
+	go vet ./...
+
 test:
 	go test ./...
 

README.md

@@ -101,6 +101,13 @@ $ github-release delete \
     --tag v0.1.0
 ```
 
+Errata
+======
+
+The `release` command does not have an `--auth-user` flag because in practice,
+Github ignores the `--auth-user` flag when validating releases. The only thing
+that matters is passing a token that has permission to create the release.
+
 GitHub Enterprise Support
 =========================
 You can point to a different GitHub API endpoint via the environment variable ```GITHUB_API```:

cmd.go

@@ -354,10 +354,17 @@ func releasecmd(opt Options) error {
 	}
 	reader := bytes.NewReader(payload)
 
-	URL := nvls(EnvApiEndpoint, github.DefaultBaseURL) + fmt.Sprintf("/repos/%s/%s/releases", user, repo)
-	resp, err := github.DoAuthRequest("POST", URL, "application/json", token, nil, reader)
+	// NB: Github appears to ignore the user here - the only thing that seems to
+	// matter is that the token is valid.
+	client := github.NewClient(user, token, nil)
+	client.SetBaseURL(EnvApiEndpoint)
+	req, err := client.NewRequest("POST", fmt.Sprintf("/repos/%s/%s/releases", user, repo), reader)
 	if err != nil {
-		return fmt.Errorf("while submitting %v, %v", string(payload), err)
+		return fmt.Errorf("while submitting %v: %w", string(payload), err)
+	}
+	resp, err := client.Do(req)
+	if err != nil {
+		return fmt.Errorf("while submitting %v: %w", string(payload), err)
 	}
 	defer resp.Body.Close()
 

github/github.go

@@ -158,7 +158,7 @@ func init() {
 }
 
 // Caller is responsible for reading and closing the response body.
-func (c Client) do(r *http.Request) (*http.Response, error) {
+func (c Client) Do(r *http.Request) (*http.Response, error) {
 	// Pulled this out of client.go:Do because we need to read the response
 	// headers.
 	var res *http.Response
@@ -217,7 +217,7 @@ func (c Client) getPaginated(uri string) (io.ReadCloser, error) {
 	if err != nil {
 		return nil, err
 	}
-	resp, err := c.do(req)
+	resp, err := c.Do(req)
 	if err != nil {
 		return nil, err
 	}
@@ -251,7 +251,7 @@ func (c Client) getPaginated(uri string) (io.ReadCloser, error) {
 				w.CloseWithError(err)
 				return
 			}
-			resp, err := c.do(req)
+			resp, err := c.Do(req)
 			if err != nil {
 				w.CloseWithError(err)
 				return