Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v10.4.12 #2014

Merged
merged 8 commits into from
Nov 5, 2024
Merged

Release v10.4.12 #2014

merged 8 commits into from
Nov 5, 2024

Conversation

smalluban
Copy link
Collaborator

8708ea1 Fix: adblocker surrogate script injection (#2013)
78533f0 fix(options): decouple observe from options (#2003)
b8a3f0c More dependabot groups (#2010)
16598c8 CI: Integrate addons-linter (#1992)
71e08b5 Rename @cliqz/adblocker to @ghostery/adblocker (#1993)
fb2de2e Update extension summary (#2005)
0bf257e fix: fallback sender.url on Safari (#1996)
41d8953 fix: update platforms manifest configuration (#1994)
66d94ee fix(panel): add meta for dark mode in Safari macOS (#1989)
43f701a Ad-blocking: improve scriptlet injection (#1977)
d4f6b1d fix(panel): menu layout improvements (#1981)

@smalluban smalluban added the package CI: create extension packages label Oct 30, 2024
@smalluban smalluban requested a review from AdamGhst October 30, 2024 14:07
@smalluban smalluban force-pushed the release branch 2 times, most recently from 4fe6208 to 0540b8e Compare October 30, 2024 14:21
@ghostery ghostery deleted a comment from github-actions bot Oct 30, 2024
@ghostery ghostery deleted a comment from github-actions bot Oct 30, 2024
Copy link

@AdamGhst AdamGhst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WINDOWS
Chromium and FF.
All smoke tests PASSED

MacOS
Chromium and FF
All smoke tests PASSED

SAFARI.
Compared to previous version, REGIONAL FILTERS are not working.
Other tests PASSED

@smalluban
Copy link
Collaborator Author

smalluban commented Oct 31, 2024

My results of testing regional filters. @AdamGhst Next time, if there is a failure in tests, please provide a reproducible path for that specific test. I am not sure if you were testing regional filters exactly as the tests document says.

Safari 18.0.1 (macOS) - works just fine...

Without regional filters (pl):

Zrzut ekranu 2024-10-31 o 10 54 49

With regional filters (pl)

Zrzut ekranu 2024-10-31 o 10 54 57

@smalluban smalluban requested a review from AdamGhst October 31, 2024 09:58
@AdamGhst
Copy link

AdamGhst commented Nov 1, 2024

My results of testing regional filters. @AdamGhst Next time, if there is a failure in tests, please provide a reproducible path for that specific test. I am not sure if you were testing regional filters exactly as the tests document says.

Safari 18.0.1 (macOS) - works just fine...

Without regional filters (pl):

Zrzut ekranu 2024-10-31 o 10 54 49 ### With regional filters (pl) Zrzut ekranu 2024-10-31 o 10 54 57

No problem Dominik.
Thanks for checking.

My scenario was exactly as in the test.
My Safari was outdated. Its up to date. I made whole testing again and everything is fine.

@ghostery ghostery deleted a comment from github-actions bot Nov 4, 2024
@ghostery ghostery deleted a comment from github-actions bot Nov 4, 2024
@ghostery ghostery deleted a comment from github-actions bot Nov 5, 2024
@ghostery ghostery deleted a comment from github-actions bot Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

@smalluban smalluban requested a review from AdamGhst November 5, 2024 13:40
Copy link

github-actions bot commented Nov 5, 2024

Copy link

@AdamGhst AdamGhst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAFARI re-tested.
All tests done and passed.
Works like a Safari.

@smalluban smalluban merged commit dca9476 into main Nov 5, 2024
2 checks passed
@smalluban smalluban deleted the release branch November 5, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package CI: create extension packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants