Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Appveyor #117

Merged
merged 4 commits into from
Jul 6, 2016
Merged

Setup Appveyor #117

merged 4 commits into from
Jul 6, 2016

Conversation

gtramontina
Copy link
Collaborator

@gtramontina gtramontina commented Jul 4, 2016

As suggested by @ta2edchimp on #114 (comment)


Interestingly enough, a few tests fail running on windows. Three of them are / vs. \ on assertions… (classic! 😛) The fourth and last one is related to setting the PATH… I'll look into those tomorrow.

The last failed test still persists. I'll need a bit more time to investigate as maybe I'll require a VM do help out (or, in the meanwhile, someone could 👀 spot what the issue might be 😉).

I've also made continuous-integration/travis-ci/pr required for PRs to be merged. And as soon as this one gets in (I'm planning on fixing the tests on this same PR), I'll make continuous-integration/appveyor/pr also required… Does this seem reasonable?

@codecov-io
Copy link

codecov-io commented Jul 4, 2016

Current coverage is 100%

Merging #117 into master will not change coverage

@@           master   #117   diff @@
====================================
  Files           4      4          
  Lines         118    118          
  Methods         0      0          
  Messages        0      0          
  Branches        4      4          
====================================
  Hits          118    118          
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last updated by e3e552a...bcfea36

@gtramontina gtramontina force-pushed the gtramontina/appveyor branch from d541c13 to 861a4c5 Compare July 4, 2016 14:36
@ta2edchimp
Copy link
Collaborator

Hmm... The path manipulations within the tests aren't os/path.sep agnostic yet 😞

@gtramontina gtramontina force-pushed the gtramontina/appveyor branch from 612e39f to 4bc83c0 Compare July 4, 2016 15:07
Use `path.resolve` instead of to manually joining
strings with OS-specific path separator.
@gtramontina gtramontina force-pushed the gtramontina/appveyor branch from 4bc83c0 to bcfea36 Compare July 4, 2016 15:22
@gtramontina
Copy link
Collaborator Author

gtramontina commented Jul 4, 2016

Updated the PR description:

The last failed test still persists. I'll need a bit more time to investigate as maybe I'll require a VM do help out (or, in the meanwhile, someone could 👀 spot what the issue might be 😉).

Reason:

1) runner should alter the path:
     AssertionError: expected undefined to start with C:\projects\ghooks\node_modules\.bin

@ta2edchimp
Copy link
Collaborator

Browsed a bit on the tablet. It's calledOptions.env[getPathVar()] resolving to undefined.
After a quick lookup for manage-path's get-path-var method, it returns "PATH".
I guess we should pass process.env and process.platform as arguments to getPathVar.

Maybe @kentcdodds can approve this assumption?

@ta2edchimp
Copy link
Collaborator

On a side note, I don't know ... shouldn't the platform be win64 or sth. like that on modern Windows?

@gtramontina
Copy link
Collaborator Author

We can also setup Appveyor to run on the different architectures. Although simply running on the different versions of node already takes forever!

Feel free to take over this branch… I'm going 💤 now… pretty late here. 😄
I'll continue on it tomorrow, anyway…

@kentcdodds
Copy link
Contributor

LGTM. Could we turn off gitcop? It's kind of annoying and heavy-handed...

@gtramontina
Copy link
Collaborator Author

Done! 👍 Gitcop is gone!

@kentcdodds
Copy link
Contributor

FYI, it's been my experience that AppVeyor takes FOREVER.

@gtramontina
Copy link
Collaborator Author

Yeap… It just finished running the tests on the different node versions…
Let's have it like this and later look at how much it is dragging us. It may be the case that we set it up to test against only one version of node…

@gtramontina gtramontina changed the title [WIP] Setup Appveyor Setup Appveyor Jul 6, 2016
@gtramontina gtramontina merged commit 16d7a6f into master Jul 6, 2016
@gtramontina gtramontina deleted the gtramontina/appveyor branch July 6, 2016 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants