-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Appveyor #117
Setup Appveyor #117
Conversation
Current coverage is 100%@@ master #117 diff @@
====================================
Files 4 4
Lines 118 118
Methods 0 0
Messages 0 0
Branches 4 4
====================================
Hits 118 118
Misses 0 0
Partials 0 0
|
It uses the same settings as `.travis.yml`.
d541c13
to
861a4c5
Compare
Hmm... The path manipulations within the tests aren't os/path.sep agnostic yet 😞 |
612e39f
to
4bc83c0
Compare
Use `path.resolve` instead of to manually joining strings with OS-specific path separator.
4bc83c0
to
bcfea36
Compare
Updated the PR description:
Reason:
|
Browsed a bit on the tablet. It's Maybe @kentcdodds can approve this assumption? |
On a side note, I don't know ... shouldn't the platform be |
We can also setup Appveyor to run on the different architectures. Although simply running on the different versions of node already takes forever! Feel free to take over this branch… I'm going 💤 now… pretty late here. 😄 |
LGTM. Could we turn off gitcop? It's kind of annoying and heavy-handed... |
Done! 👍 Gitcop is gone! |
FYI, it's been my experience that AppVeyor takes FOREVER. |
Yeap… It just finished running the tests on the different node versions… |
As suggested by @ta2edchimp on #114 (comment)
Interestingly enough, a few tests fail running on windows. Three of them are
/
vs.\
on assertions… (classic! 😛) The fourth and last one is related to setting the PATH…I'll look into those tomorrow.The last failed test still persists. I'll need a bit more time to investigate as maybe I'll require a VM do help out (or, in the meanwhile, someone could 👀 spot what the issue might be 😉).
I've also made
continuous-integration/travis-ci/pr
required for PRs to be merged. And as soon as this one gets in (I'm planning on fixing the tests on this same PR), I'll makecontinuous-integration/appveyor/pr
also required… Does this seem reasonable?