Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(install): instruct to use npm explore in non-git repo warning #105

Merged
merged 1 commit into from
Jun 7, 2016

Conversation

Tapppi
Copy link
Contributor

@Tapppi Tapppi commented Jun 7, 2016

Fixes #104

@Tapppi
Copy link
Contributor Author

Tapppi commented Jun 7, 2016

Dont know if the docs type makes sense, or if it should be style/refactor.. Sorry I'm still fairly new to the angular format 😞 Also forgot the fixes footer from the commit.. Ah crap.

@codecov-io
Copy link

codecov-io commented Jun 7, 2016

Current coverage is 100%

Merging #105 into master will not change coverage

@@            master      #105   diff @@
========================================
  Files            4         4          
  Lines          114       114          
  Methods          0         0          
  Messages         0         0          
  Branches         4         4          
========================================
  Hits           114       114          
  Misses           0         0          
  Partials         0         0          

Powered by Codecov. Last updated by 73262f4...04585a1

@ta2edchimp
Copy link
Collaborator

You could use git commit --amend to alter you last commits' message (I'd say style or sth. but am unsure as well considering this particular example) and force push to your remote branch. This PR would update automatically afterwards.

While thinking about it, personally I'd say even make it a fix (this would trigger a new semantic release after merging).

@kentcdodds
Copy link
Contributor

This looks fine to me. I probably wouldn't call this a docs change but a fix. But lucky for both of us, GitHub now allows me to update your commit message for you!

I'll go ahead and merge this and update the message for you :-) Thanks for the contribution!

@kentcdodds kentcdodds merged commit 4195470 into ghooks-org:master Jun 7, 2016
@Tapppi
Copy link
Contributor Author

Tapppi commented Jun 7, 2016

Thank you for the quick response! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants