Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(selection): auto-scroll the viewport when dragging with selection #584

Merged
merged 4 commits into from
Dec 20, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 20, 2021

  • implements and replicates latest SlickGrid PR #656 to auto-scroll when making cell or row selection
  • This PR allow auto scroll when dragging to make selection using SlickCellRangeSelector

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #584 (1405ac8) into master (27c617e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #584    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          230       230            
  Lines        15812     15936   +124     
  Branches      5104      5134    +30     
==========================================
+ Hits         15812     15936   +124     
Impacted Files Coverage Δ
...es/common/src/extensions/slickCellRangeSelector.ts 100.00% <100.00%> (ø)
...s/common/src/extensions/slickCellSelectionModel.ts 100.00% <100.00%> (ø)
...es/common/src/extensions/slickRowSelectionModel.ts 100.00% <100.00%> (ø)
packages/common/src/interfaces/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c617e...1405ac8. Read the comment docs.

@ghiscoding ghiscoding merged commit 941e99c into master Dec 20, 2021
@ghiscoding ghiscoding deleted the feat/drag-to-scroll-view branch December 20, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant