Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styling)!: delete "bare" Themes but keep "lite" & add to Bootstrap #1493

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Apr 29, 2024

Here's quick details about file size comparison with/without "lite" for each theme. I think Material is slightly larger because it also includes the the Roboto font family

image

Also tested in Angular-Slickgrid, all is good after migrating all .fa to .mdi icons. I also tested the "lite" edition and it works correctly too (sort, grouping, ... icons are showing but not the menu ones)

Copy link

stackblitz bot commented Apr 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.7%. Comparing base (75dce74) to head (43f9bce).

Additional details and impacted files
@@          Coverage Diff          @@
##            next   #1493   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        197     197           
  Lines      21652   21652           
  Branches    7207    7207           
=====================================
  Hits       21586   21586           
+ Misses        66      60    -6     
- Partials       0       6    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit ca5ac06 into next Apr 30, 2024
6 checks passed
@ghiscoding
Copy link
Owner Author

After testing the change in Angular-Slickgrid, I pushed a couple of small commits and I don't see any problems with this new implementation, so I'm gonna go ahead and merge.

@ghiscoding ghiscoding deleted the chore/theme-lite branch April 30, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants