Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scala 3.5.0 and 3.4.3 #24

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Support Scala 3.5.0 and 3.4.3 #24

merged 1 commit into from
Aug 28, 2024

Conversation

2m
Copy link
Contributor

@2m 2m commented Aug 28, 2024

Added override modifier because since 3.5.0 missing modifier is an error:

[info] compiling 1 Scala source to /Users/martynas/projects/zerowaste/target/scala-3.5.0/classes ...
[error] -- [E164] Declaration Error: /Users/martynas/projects/zerowaste/src/main/scala-3/com/github/ghik/zerowaste/ZerowastePlugin.scala:18:6 
[error] 18 |  def init(options: List[String]): List[PluginPhase] =
[error]    |      ^
[error]    |error overriding method init in trait StandardPlugin of type (options: List[String]): List[dotty.tools.dotc.plugins.PluginPhase];
[error]    |  method init of type (options: List[String]): List[dotty.tools.dotc.plugins.PluginPhase] needs `override` modifier
[error] one error found
[error] Total time: 3 s, completed Aug 28, 2024, 3:20:41 PM
[error] (Compile / compileIncremental) Compilation failed

@ghik ghik merged commit 5520ea3 into ghik:main Aug 28, 2024
20 checks passed
@ghik
Copy link
Owner

ghik commented Aug 28, 2024

Thanks!

@2m 2m deleted the fix/scala-3.5-2m branch August 28, 2024 18:21
@2m
Copy link
Contributor Author

2m commented Aug 29, 2024

The new release publish job failed: https://github.com/ghik/zerowaste/actions/runs/10597951965/job/29369443580

@ghik
Copy link
Owner

ghik commented Aug 29, 2024

@2m fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants