-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve map component defaultInteractionsOptions prop #215
Conversation
Thanks for contribution! |
- resolved #173, #174, #201, #135, #216, #132 #224 #225 #226, #230 - merged of pull requests #160, #175, #180, #185, #188, #191, #206, #208, #212, #213, #215, #221, #227, #231 Thanks to @baspeeters, @sjmallon, @janlazo, @categulario, @skymaze, @jemasfox, @owen-thurston, @agmt5989, @RemiDesgrange - improved property watchers - optional debug messages - fixed broken UMD version - simplified initial interaction/controls setup #95 - added `id` property for all ol components for easy identification - mixins, ol-ext and rx-ext now are build to single file package, imports from those packages are not changed - UMD version (dev/demo version) now includes all used stuff from `ol` package - updated documentation and README
- resolved #173, #174, #201, #135, #216, #132 #224 #225 #226, #230 - merged of pull requests #160, #175, #180, #185, #188, #191, #206, #208, #212, #213, #215, #221, #227, #231 Thanks to @baspeeters, @sjmallon, @janlazo, @categulario, @skymaze, @jemasfox, @owen-thurston, @agmt5989, @RemiDesgrange - improved property watchers - optional debug messages - fixed broken UMD version - simplified initial interaction/controls setup #95 - added `id` property for all ol components for easy identification - mixins, ol-ext and rx-ext now are build to single file package, imports from those packages are not changed - UMD version (dev/demo version) now includes all used stuff from `ol` package - updated documentation and README
Hello hello - I'm looking at the Master branch, and it looks like the Is there a recommended way set |
I believe the prop was changed to defaultInteractions. I think the way that was working for me was to set the prop on the vl-map. |
Hi there! |
Beautiful :) Works as expected. I'm guessing that this would be very useful to other developers. Maybe we should add it to the docs at vl-map#properties? |
Added a defaultInteractionsOptions prop to the map component to be able to pass options into the interactions defaults function when map.vue calls it.
I mainly needed a way to add the onFocusOnly boolean in so the DragPan and MouseWheelZoom interactions only activate on map focus. I tried many other ways to accomplish this without having to create a set of interactions of my own. I even tried setting the interactions on mounted and created using the defaults function the same way the map component does, but for some reason the map property didn't get set for the interactions and openlayers was logging errors to the console any time I used DragPan.