Modify the code according to the modification suggestions for msa #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## hpe_msa_2022 #516 +/- ##
================================================
+ Coverage 70.57% 70.59% +0.01%
================================================
Files 180 180
Lines 18856 18846 -10
Branches 2787 2779 -8
================================================
- Hits 13308 13304 -4
+ Misses 4695 4694 -1
+ Partials 853 848 -5
|
ghxiaobo
reviewed
Feb 25, 2022
| 'manufacturer': data.get('vendor'), | ||
| 'model': data.get('model'), | ||
| 'speed': rpm, | ||
| 'capacity': int(size), |
There was a problem hiding this comment.
Do you need to switch again here
'capacity': int(size),
There was a problem hiding this comment.
There are decimals in the return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: