Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsp add alerts get #402

Merged
merged 2 commits into from
Dec 30, 2021
Merged

vsp add alerts get #402

merged 2 commits into from
Dec 30, 2021

Conversation

tanjiangyu-ghca
Copy link

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@tanjiangyu-ghca tanjiangyu-ghca requested a review from a team December 30, 2021 09:32
@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #402 (dce29b5) into vsp_1230 (d67a1de) will increase coverage by 0.21%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##           vsp_1230     #402      +/-   ##
============================================
+ Coverage     70.34%   70.55%   +0.21%     
============================================
  Files           163      173      +10     
  Lines         15876    17655    +1779     
  Branches       2265     2570     +305     
============================================
+ Hits          11168    12457    +1289     
- Misses         4034     4437     +403     
- Partials        674      761      +87     
Impacted Files Coverage Δ
delfin/drivers/hitachi/vsp/rest_handler.py 42.13% <25.00%> (-0.40%) ⬇️
delfin/drivers/hitachi/vsp/vsp_stor.py 70.30% <37.50%> (-0.20%) ⬇️
delfin/drivers/dell_emc/vmax/client.py 73.35% <0.00%> (-2.12%) ⬇️
delfin/drivers/utils/ssh_client.py 16.81% <0.00%> (-2.07%) ⬇️
delfin/drivers/dell_emc/vmax/vmax.py 80.55% <0.00%> (-2.06%) ⬇️
delfin/drivers/dell_emc/vmax/rest.py 44.18% <0.00%> (-1.61%) ⬇️
delfin/drivers/fake_storage/__init__.py 95.06% <0.00%> (-0.55%) ⬇️
delfin/drivers/driver.py 61.76% <0.00%> (-0.36%) ⬇️
delfin/common/constants.py 100.00% <0.00%> (ø)
delfin/task_manager/tasks/resources.py 86.73% <0.00%> (ø)
... and 13 more

@tanjiangyu-ghca tanjiangyu-ghca merged commit 00f4872 into gh-ca:vsp_1230 Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant