CUDA: Add fastdiv
to k_bin_bcast*
, giving 1-3% E2E performance
#15872
+112
−75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies
fastdiv
andfastmodulo
introduced by #15715 tok_bin_bcast
andk_bin_bcast_unravel
, giving around 1-3% E2E performance on Ada Lovelace and Blackwell GPUs.While changing host logic in
launch_bin_bcast_pack
I was surprised to see we keepne*
in 64 bit precision, but use only the 32 least significant bits in the actual kernel. This could potentially lead to some semantic bugs where we do not iterate over all elements ofsrc0
/src1
, or am I missing something here?Perf numbers