Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python logging refactoring and flake8 suppression refactoring #7081

Merged
merged 1 commit into from
May 5, 2024

Conversation

mofosyne
Copy link
Collaborator

@mofosyne mofosyne commented May 5, 2024

This continues from #7070 to address @teleprint-me suggestion and that @ggerganov already addressed one script but may have missed another.

Set one as executable and add basicConfig()
to another. Also added noqa tag to test scripts.
@ggerganov ggerganov merged commit 6fbd432 into ggerganov:master May 5, 2024
22 checks passed
@mofosyne mofosyne deleted the add-logging-basic-config branch May 5, 2024 07:49
nopperl pushed a commit to nopperl/llama.cpp that referenced this pull request May 5, 2024
Set one as executable and add basicConfig()
to another. Also added noqa tag to test scripts.
teleprint-me pushed a commit to teleprint-me/llama.cpp that referenced this pull request May 7, 2024
Set one as executable and add basicConfig()
to another. Also added noqa tag to test scripts.
@mofosyne mofosyne added bugfix fixes an issue or bug Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix python python script changes labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixes an issue or bug python python script changes Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants