-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add an option to fail on compile warning #3952
feat(ci): add an option to fail on compile warning #3952
Conversation
I think you are cherry-picking from master when you should be merging from it or rebasing on it. |
There's no need to close the PR, just fix whatever you need to on your end (e.g. making a new branch, putting your changes on it without the extra commits, then checking out this branch again and running |
adb41e5
to
a1d7cca
Compare
cd78f4b
to
b39ae69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge this after the CI is green
ggml-ci
I don't think this works correctly with GNU systems,
|
It looks like ifeq '' '$(findstring clang,$(shell $(CC) --version))'
CC_IS_GCC=1
CC_VER := $(shell $(CC) -dumpfullversion -dumpversion | awk -F. '{ printf("%02d%02d%02d", $$1, $$2, $$3) }')
else
CC_IS_CLANG=1
ifeq '' '$(findstring Apple LLVM,$(shell $(CC) --version))'
CC_IS_LLVM_CLANG=1
else
CC_IS_APPLE_CLANG=1
endif
CC_VER := $(shell $(CC) --version | sed -n 's/^.* version \([0-9.]*\).*$$/\1/p' \
| awk -F. '{ printf("%02d%02d%02d", $$1, $$2, $$3) }')
endif |
* build : pass all warning flags to nvcc via -Xcompiler * make : fix apparent mis-merge from #3952 * make : fix incorrect GF_CC_VER for CUDA host compiler
* feat(ci): add an option to fail on compile warning * Update CMakeLists.txt * minor : fix compile warnings ggml-ci * ggml : fix unreachable code warnings ggml-ci * ci : disable fatal warnings for windows, ios and tvos * ggml : fix strncpy warning * ci : disable fatal warnings for MPI build * ci : add fatal warnings to ggml-ci ggml-ci --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
* build : pass all warning flags to nvcc via -Xcompiler * make : fix apparent mis-merge from ggerganov#3952 * make : fix incorrect GF_CC_VER for CUDA host compiler
* feat(ci): add an option to fail on compile warning * Update CMakeLists.txt * minor : fix compile warnings ggml-ci * ggml : fix unreachable code warnings ggml-ci * ci : disable fatal warnings for windows, ios and tvos * ggml : fix strncpy warning * ci : disable fatal warnings for MPI build * ci : add fatal warnings to ggml-ci ggml-ci --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
* build : pass all warning flags to nvcc via -Xcompiler * make : fix apparent mis-merge from ggerganov#3952 * make : fix incorrect GF_CC_VER for CUDA host compiler
Add optional flags to the build system[make and CMake] to fail upon compile warnings. These flags are disabled by default so that during the development this does not interfere.
fix #3899