Reenable tokenizer test for LLaMa #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work on compiler warnings.
ggerganov
approved these changes
Sep 13, 2023
This was referenced Sep 14, 2023
Merged
pkrmf
pushed a commit
to morlockstudios-com/llama.cpp
that referenced
this pull request
Sep 26, 2023
…ov#3096) * Fix für ggerganov#2721 * Reenable tokenizer test for LLaMa * Add `console.cpp` dependency * Fix dependency to `common` * Fixing wrong fix. * Make console usage platform specific Work on compiler warnings. * Adapting makefile * Remove trailing whitespace * Adapting the other parts of the makefile * Fix typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes I see the following output for
test-tokenizer-1compared to the original tokenizer output
I believe the problems with token 3 and codepoint 0 are due to the C interface. I also think we still have problems with
sentencepiecebytes above 127 (compare the decoding with the ground truth), which I'm unsure how to solve.