Streaming conversion with no torch #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| q = queue.Queue(maxsize=2) | ||
|
|
||
| def writer(): | ||
| while True: |
There was a problem hiding this comment.
while True? Does this function ever return? I don't know if the function exists but maybe something like while !q.atEnd()
Please correct me if I'm wrong. I haven't worked with Python since a year or so.
gjmulder
added
enhancement
|
The python dependencies in .devops/full.Dockerfile should also be updated, will conflict with my PR #293. |
|
This looks like a very useful addition. Lets give it a priority and merge after resolving the conflicts |
|
@ggerganov Any update on this? Because I really do not want to install pytorch on my system (because of memory). |
|
This is probably too outdated so closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop torch, do not load whole file into memory, process files in parallel and use separate threads for r/w