Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples : fix benchmark-matmult #1554

Merged
merged 1 commit into from
Sep 20, 2023
Merged

examples : fix benchmark-matmult #1554

merged 1 commit into from
Sep 20, 2023
+15 −13

Conversation

ggerganov
Copy link
Owner

The precision for Q4_0 has degraded since #1508
Use Q4_1 instead

ref #1551

@ggerganov
examples : fix benchmark-matmult
b16c085 
The precision for Q4_0 has degraded since #1508
stsydow
stsydow approved these changes May 21, 2023
View reviewed changes
Copy link
Contributor

@stsydow stsydow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested for Q5.1 and it seem to work as well.

@cebtenzzre
Copy link
Collaborator

Could we merge this? I was going to fix the use of abs instead of std::abs in the delta calculation and add a few missing static qualifiers, but there's no point if the example doesn't even run successfully.

@ggerganov ggerganov merged commit d119c04 into master Sep 20, 2023
@ggerganov ggerganov deleted the fix-benchmark-matmult branch September 20, 2023 07:02
pkrmf pushed a commit to morlockstudios-com/llama.cpp that referenced this pull request Sep 26, 2023
@ggerganov @pkrmf
examples : fix benchmark-matmult (ggerganov#1554)
487e22a 
The precision for Q4_0 has degraded since ggerganov#1508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsydow stsydow stsydow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggerganov @cebtenzzre @stsydow