Fix for mingw compilers (including wx64devkit) - fixes #1423 fixes #1529

[DannyDaemonic]

It seems mingw's version of getwchar can get stuck in an infinite loop.

It's easy to repeat in one piece of code.

#include <windows.h>
#include <winnls.h>
#include <fcntl.h>
#include <wchar.h>
#include <stdio.h>
#include <io.h>

int main() {
    // Initialize for reading wchars and writing out UTF-8
    DWORD dwMode = 0;
    HANDLE hConsole = GetStdHandle(STD_OUTPUT_HANDLE);
    if (hConsole == INVALID_HANDLE_VALUE || !GetConsoleMode(hConsole, &dwMode)) {
        hConsole = GetStdHandle(STD_ERROR_HANDLE);
        if (hConsole != INVALID_HANDLE_VALUE && (!GetConsoleMode(hConsole, &dwMode))) {
            hConsole = NULL;
        }
    }
    if (hConsole) {
        SetConsoleMode(hConsole, dwMode | ENABLE_VIRTUAL_TERMINAL_PROCESSING);
        SetConsoleOutputCP(CP_UTF8);
    }
    HANDLE hConIn = GetStdHandle(STD_INPUT_HANDLE);
    if (hConIn != INVALID_HANDLE_VALUE && GetConsoleMode(hConIn, &dwMode)) {
        _setmode(_fileno(stdin), _O_WTEXT);
        dwMode &= ~(ENABLE_LINE_INPUT | ENABLE_ECHO_INPUT);
        SetConsoleMode(hConIn, dwMode);
    }

    // Echo input
    while (1) {
        // Read
        wchar_t wcs[2] = { getwchar(), L'\0' };
        if (wcs[0] == WEOF) break;
        if (wcs[0] >= 0xD800 && wcs[0] <= 0xDBFF) { // If we have a high surrogate...
            wcs[1] = getwchar(); // Read the low surrogate
            if (wcs[1] == WEOF) break;
        }
        // Write
        char utf8[5] = {0};
        int result = WideCharToMultiByte(CP_UTF8, 0, wcs, (wcs[1] == L'\0') ? 1 : 2, utf8, 4, NULL, NULL);
        if (result > 0) {
            printf("%s", utf8);
        }
    }
    return 0;
}

The code works when compiled with MS's compiler (and Intel's) but I guess getwchar is a weird enough function that no one uses it and it's untested on mingw. The Windows functions themselves are much more well tested and supported in misc compilers, so that's what I changed the code to use.

Edit: Confirmed to fix #1423 and #1529.

[DannyDaemonic]

Verified: #1423 (comment)

[newTomas]

Works for me

[Folko-Ven]

Hi, everything was working before #1509. The compilation now gives errors. Could you please request a review and merge it finally?

[DannyDaemonic]

Yeah, I've been sick so most of my stuff has just been sitting.

You should open a new issue for the problem with #1509. I can't imagine it's related to this in any other way than the compiler again, mingw.

[Folko-Ven]

Well, that’s strange. I tried again just git pull origin master 175aff7a4e1735dc7d4b79f9b10b49b8faa32db0, compiled it, and it worked totally fine. I don’t know why I had errors last time.

[DannyDaemonic]

Maybe you just needed a make clean? Whenever I get a compiling error after a pull I do a make clean && make.

[Folko-Ven]

Yes, this is possible. Usually I use a homemade powershell script to update, and there I run make clean make -B. I guess I forgot to do this in manual mode :)

[DannyDaemonic]

I don't know who else to request a review from. Is anyone else familiar with the Windows API?

[Folko-Ven]

If there is no one else, maybe ask ggerganov? I have been using your fix for four days now and everything is working well.

[ggerganov]

I don't have Windows to test, but if people confirm it is working - please merge it