Allow locally downloaded models for QwenVL #10833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
What trailing white space is it complaining about 🤔 |
ngxson
reviewed
Dec 14, 2024
ggerganov
approved these changes
Dec 15, 2024
|
There is still a trailing whitespace. |
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Dec 20, 2024
* Allow locally downloaded models for QwenVL * Define model_path * rm trailing space --------- Co-authored-by: Xuan Son Nguyen <thichthat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation requires passing a HF model path, this allows passing a local path instead
This change is mediocre and should be improved across the board to more resemble other llava surgery files, but for now this should unblock people wanting to make vision conversions
Make sure to read the contributing guidelines before submitting a PR