Deduplicate BindGroupLayout by value #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
There was a problem hiding this comment.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
cwfitzgerald
approved these changes
Jun 27, 2020
There was a problem hiding this comment.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
cwfitzgerald
requested changes
Jun 27, 2020
|
Awesome! |
bors bot
added a commit
that referenced
this pull request
Jun 27, 2020
753: Deduplicate BindGroupLayout by value r=cwfitzgerald a=kvark **Connections** Fixes #335 **Description** BGL now has distinct `MultiRefCount` type with a bit of a hacky logic to support deduplication. Good review is needed! **Testing** Ran wgpu-rs examples. The actual new logic is NOT tested enough! Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
|
Canceled. |
There was a problem hiding this comment.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
|
Just made both refcount bumps to be consistent here. |
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
753: Use max function to ensure that the swapchain size is not less than 1. r=kvark a=Tnze ATT Co-authored-by: Tnze <cjd001113@outlook.com>
Patryk27
pushed a commit
to Patryk27/wgpu
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #335
Description
BGL now has distinct
MultiRefCounttype with a bit of a hacky logic to support deduplication.Good review is needed!
Testing
Ran wgpu-rs examples.
The actual new logic is NOT tested enough!