Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose FeaturesWGPU & FeaturesWebGPU via wgpu crate & implement From #7086

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 8, 2025

Connections

Description
see title

Testing
added test

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@Wumpf Wumpf requested a review from a team as a code owner February 8, 2025 16:51
@Wumpf Wumpf force-pushed the feature-split-addendum branch from 00b0a1d to 0d8834c Compare February 8, 2025 16:51
@Wumpf Wumpf mentioned this pull request Feb 8, 2025
25 tasks
@Wumpf
Copy link
Member Author

Wumpf commented Feb 8, 2025

@Vecvec let me know what you think :)

}
}
)*
};
}
Copy link
Member Author

@Wumpf Wumpf Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only moved those down with some whitespaces, otherwise untouched

Copy link
Contributor

@Vecvec Vecvec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, since there were already other from traits it makes sense for the internal features to have from traits too.

@nical nical merged commit e5e7138 into gfx-rs:trunk Feb 10, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants