Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transform buffer when building blas #7062

Merged
merged 19 commits into from
Feb 11, 2025
Merged

Conversation

Vecvec
Copy link
Contributor

@Vecvec Vecvec commented Feb 5, 2025

Connections

Description
When creating a BLAS we don't say whether we will be using a transform buffer, but both Vulkan and DirectX check whether the transform buffer (only the transform buffer) is non null. This adds AccelerationStructureFlags::USE_TRANSFORM which is required if building with a transform buffer and disallowed if building without one.

Testing
No extra test was added because the transform buffer test was fixed by this (on nVidia).

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • [n/a] --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Sorry, something went wrong.

@Vecvec Vecvec requested a review from a team as a code owner February 5, 2025 20:27
@Vecvec Vecvec changed the title Fix transform Fix transform buffer when building blas Feb 5, 2025
Vecvec and others added 3 commits February 7, 2025 07:10
@Vecvec
Copy link
Contributor Author

Vecvec commented Feb 6, 2025

There also is a zero buffer in wgpu-core, I'll see if I can wire that down to these places.

Vecvec and others added 9 commits February 7, 2025 09:04
@Vecvec Vecvec requested a review from nical February 8, 2025 19:26
@cwfitzgerald cwfitzgerald merged commit 0922631 into gfx-rs:trunk Feb 11, 2025
33 checks passed
@cwfitzgerald cwfitzgerald deleted the fix-transform branch February 11, 2025 01:18
marcpabst pushed a commit to marcpabst/wgpu that referenced this pull request Feb 19, 2025
Co-authored-by: Nicolas Silva <nical@fastmail.com>
davnotdev pushed a commit to davnotdev/wgpu that referenced this pull request Mar 4, 2025
Co-authored-by: Nicolas Silva <nical@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants