Fix transform buffer when building blas #7062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
reviewed
Feb 6, 2025
|
There also is a zero buffer in wgpu-core, I'll see if I can wire that down to these places. |
nical
reviewed
Feb 10, 2025
nical
approved these changes
Feb 10, 2025
marcpabst
pushed a commit
to marcpabst/wgpu
that referenced
this pull request
Feb 19, 2025
Co-authored-by: Nicolas Silva <nical@fastmail.com>
davnotdev
pushed a commit
to davnotdev/wgpu
that referenced
this pull request
Mar 4, 2025
Co-authored-by: Nicolas Silva <nical@fastmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
When creating a BLAS we don't say whether we will be using a transform buffer, but both Vulkan and DirectX check whether the transform buffer (only the transform buffer) is non null. This adds
AccelerationStructureFlags::USE_TRANSFORMwhich is required if building with a transform buffer and disallowed if building without one.Testing
No extra test was added because the transform buffer test was fixed by this (on nVidia).
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.