-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start using hashbrown
#6925
Start using hashbrown
#6925
Conversation
Definitely needed. Bevy relied on |
hashbrown
in wgpu-core
& wgpu-hal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
hashbrown
in wgpu-core
& wgpu-hal
hashbrown
in multiple crates
I think this should be ready now, thanks everyone for the quick reviews. |
Connections
Description
see title
Use
hashbrown
inwgpu-core
,wgpu-hal
&wgpu-info
to simplify no-std support. (This may help improve performance as well.)Holding off on updating the following crates to use hashbrown:
naga
- I encountered some build issues withspirv::Capability
. I think using hashbrown innaga
would be good for no-std build, without the spirv-related feature.wgpu
crate - I encountered some issues testing with webgpu backend & did not feel like introducing a possibly breaking change to the public API. I may revisit this (someday).Testing
cargo build --all-features -p wgpu-core
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.