Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise Vulkan/DX12/GL max_color_attachment_bytes_per_sample Limit #6866

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Raise Vulkan/DX12/GL max_color_attachment_bytes_per_sample Limit #6866

merged 1 commit into from
Jan 7, 2025

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Jan 6, 2025 •
edited
Loading

Closes #6853

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner January 6, 2025 22:31
@cwfitzgerald cwfitzgerald force-pushed the cw/raise-attachment-bytes-per-sample branch from 039eb1b to c490293 Compare January 6, 2025 22:53
ErichDonGubler
ErichDonGubler approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minus noting that I didn't have enough time to validate: This still only reports 32 unless a user requests a higher limit, right?

@cwfitzgerald
Copy link
Member Author

LGTM, minus noting that I didn't have enough time to validate: This still only reports 32 unless a user requests a higher limit, right?

adapter.limits() will show the real limit. Validation will use 32 unless explicitly raised in DeviceDescriptor::required_limits

@cwfitzgerald cwfitzgerald merged commit 4124fbf into trunk Jan 7, 2025
27 checks passed
@cwfitzgerald cwfitzgerald deleted the cw/raise-attachment-bytes-per-sample branch January 7, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vulkan] Different behaviour for max_color_attachment_bytes_per_sample in 23.0
2 participants
@cwfitzgerald @ErichDonGubler