Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly enable dx12 & metal features on wgpu-info #6844

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 2, 2025

Connections

Description

We didn't show dx12 adapters on wgpu-info anymore 😬

Testing
Run cargo run -p wgpu-info

Before: Dx12 doesn't show up
After: Dx12 shows up

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@Wumpf
Copy link
Member Author

Wumpf commented Jan 2, 2025

huh, so ci is happy with it. Was curious if it would be. Need to prod this some more

@Wumpf
Copy link
Member Author

Wumpf commented Jan 3, 2025

Answered here, I need to updated my visual studio

@Wumpf Wumpf force-pushed the enable-dx12-wgpu-info branch from 85453a0 to 8676212 Compare January 3, 2025 09:05
@Wumpf Wumpf marked this pull request as ready for review January 3, 2025 09:05
@Wumpf Wumpf requested a review from a team as a code owner January 3, 2025 09:05
@cwfitzgerald cwfitzgerald merged commit 959c2db into gfx-rs:trunk Jan 3, 2025
27 checks passed
@Wumpf Wumpf deleted the enable-dx12-wgpu-info branch January 3, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants