Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove claimed support for an unsupported feature on dx12. #6724

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

Vecvec
Copy link
Contributor

@Vecvec Vecvec commented Dec 13, 2024

Connections
None

Description
Features::BUFFER_BINDING_ARRAY claimed it was supported on directx 12 but actually wasn't being set. @cwfitzgerald suggested removing the docs on matrix.

Testing
doesn't need tests

Checklist

  • Run cargo fmt.
  • [n/a] Run taplo format.
  • [n/a] Run cargo clippy. If applicable, add:
    • [n/a] --target wasm32-unknown-unknown
    • [n/a] --target wasm32-unknown-emscripten
  • [n/a] Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file. As this is a small docs change it probably doesn't need this.

@Vecvec Vecvec requested a review from a team as a code owner December 13, 2024 20:40
@cwfitzgerald cwfitzgerald merged commit 3cc63af into gfx-rs:trunk Dec 13, 2024
27 checks passed
@cwfitzgerald cwfitzgerald deleted the remove-docs-line branch December 13, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants