-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid cloning Arcs unnecessarily when iterating trackers #6721
Merged
+11
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a3617a
to
2e7808c
Compare
2e7808c
to
28aaecd
Compare
cwfitzgerald
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that's very cool
kentslaney
pushed a commit
to kentslaney/wgpu
that referenced
this pull request
Dec 16, 2024
* Avoid cloning Arcs unnecessarily when iterating trackers * Changelog entry
I ran the benchmark on a rather stable desktop CPU:
Overall a pretty good improvement on most benchmarks with up to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in
validate_command_buffer
we spend a fair amount of CPU time cloning/dropping arcs while iterating trackers, just to peak into the contents of the buffer or textures (so we don't really need to hold on to the arcs and touch the reference counts).This PR avoids that by iterating over references to the arcs instead of clones of the arcs.
I'm in a train and running low on battery so I can't properly record some numbers from the benchmarks right now, but when I ran them earlier I was seeing some non-trivial improvements in the order of 10% for some benchmark).
Checklist
cargo fmt
.cargo clippy
.cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.