Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix being able to use storage textures without TEXTURE_ADAPTER_SPECIFIC_FORMAT_FEATURES #6690

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix being able to use storage textures without TEXTURE_ADAPTER_SPECIFIC_FORMAT_FEATURES #6690

merged 2 commits into from
Dec 10, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Dec 9, 2024

Follow-up to #6642. See #6642 (comment).

@teoxoy
fix being able to use storage textures without `TEXTURE_ADAPTER_SPECI…
0fe0fc3 
…FIC_FORMAT_FEATURES`

cleanup `TextureUses::STORAGE_*` flags
@teoxoy teoxoy requested a review from a team as a code owner December 9, 2024 21:36
@ErichDonGubler ErichDonGubler added type: bug Something isn't working area: validation Issues related to validation, diagnostics, and error handling labels Dec 10, 2024
@teoxoy teoxoy removed their assignment Dec 10, 2024
ErichDonGubler
ErichDonGubler reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partway through reviews here, just letting questions and commentary loose that I don't think needs to wait until I'm finished.

wgpu-hal/src/lib.rs Show resolved Hide resolved
wgpu-core/src/conv.rs Show resolved Hide resolved
wgpu-hal/src/dx12/adapter.rs Show resolved Hide resolved
ErichDonGubler
ErichDonGubler approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ErichDonGubler ErichDonGubler merged commit a1fc2ba into gfx-rs:trunk Dec 10, 2024
27 checks passed
@atlv24 atlv24 mentioned this pull request Dec 11, 2024
Merged
7 tasks
@teoxoy teoxoy deleted the usages branch December 11, 2024 13:50
kentslaney pushed a commit to kentslaney/wgpu that referenced this pull request Dec 16, 2024
@teoxoy @ErichDonGubler @kentslaney
fix being able to use storage textures without `TEXTURE_ADAPTER_SPECI…
0b35651 
…FIC_FORMAT_FEATURES` (gfx-rs#6690)

Co-authored-by: Erich Gubler <erichdongubler@gmail.com>
@teoxoy teoxoy mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler approved these changes

Assignees

@ErichDonGubler ErichDonGubler

Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working
Projects
WebGPU for Firefox
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoxoy @ErichDonGubler