Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naga: add types to InvalidBinaryOperandTypes error msg #6450

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Oct 23, 2024

Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories

Description
Describe what problem this is solving, and how it's solved.

Testing
Explain how this change is tested.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-vwpuonuxytrn branch from 50683db to 3691009 Compare October 23, 2024 16:42
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-vwpuonuxytrn branch 3 times, most recently from 04a2a1b to 8f6190f Compare November 4, 2024 19:38
@ErichDonGubler ErichDonGubler marked this pull request as ready for review November 5, 2024 14:36
@ErichDonGubler ErichDonGubler requested a review from a team November 5, 2024 14:36
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ErichDonGubler ErichDonGubler self-assigned this Nov 5, 2024
@ErichDonGubler ErichDonGubler added type: enhancement New feature or request kind: diagnostics Error message should be better naga Shader Translator area: validation Issues related to validation, diagnostics, and error handling labels Nov 5, 2024
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-vwpuonuxytrn branch 2 times, most recently from 12c9a69 to 4254ec5 Compare November 12, 2024 13:55
@ErichDonGubler ErichDonGubler enabled auto-merge (rebase) November 12, 2024 13:55
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-vwpuonuxytrn branch from 4254ec5 to fdc5ccd Compare November 12, 2024 13:57
@ErichDonGubler ErichDonGubler merged commit e8a8281 into gfx-rs:trunk Nov 12, 2024
27 checks passed
@ErichDonGubler ErichDonGubler deleted the erichdongubler/push-vwpuonuxytrn branch November 12, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: validation Issues related to validation, diagnostics, and error handling kind: diagnostics Error message should be better naga Shader Translator type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants