Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove #[no_mangle] … extern "C" … from fns in bundle_ffi #6272

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Sep 14, 2024

Connections

Resolves #3105.

Description

Remove the last remaining cases that should trigger #3105 in the wgpu_core::command::bundle::bundle_ffi module.

Testing

If things still compile, we just gotta check that this doesn't break downstream. @cwfitzgerald, halp plz?

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Wumpf

This comment was marked as resolved.

@ErichDonGubler

This comment was marked as resolved.

@nical

This comment was marked as resolved.

@ErichDonGubler ErichDonGubler force-pushed the no-exposed-render_bundle-c-symbols branch from 144fa41 to d0c5e58 Compare September 21, 2024 14:13
@ErichDonGubler ErichDonGubler changed the title chore!: remove extern "C" and unsafe from bundle_ffi module fns chore!: remove #[no_mangle] … extern "C" … from fns in bundle_ffi Sep 21, 2024
@ErichDonGubler
Copy link
Member Author

I have a patch ready to go on the Firefox side, and I've confirmed it compiles: D223052

So we should be good to merge this! 😀

@ErichDonGubler ErichDonGubler force-pushed the no-exposed-render_bundle-c-symbols branch from d0c5e58 to df05571 Compare September 21, 2024 16:21
@ErichDonGubler ErichDonGubler force-pushed the no-exposed-render_bundle-c-symbols branch from df05571 to d3a432c Compare September 21, 2024 16:22
@ErichDonGubler ErichDonGubler enabled auto-merge (squash) September 21, 2024 16:22
@ErichDonGubler

This comment was marked as resolved.

@ErichDonGubler ErichDonGubler merged commit 9977edc into gfx-rs:trunk Sep 21, 2024
27 checks passed
@ErichDonGubler ErichDonGubler deleted the no-exposed-render_bundle-c-symbols branch September 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Using multiple major versions of wgpu causes linker errors
3 participants