-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo doing less bench iterations under cfg(test)
#6021
Conversation
I think we should lower the numbers as the mac CI is now intermittently timing out. It was close to timing out in this PR, timed out on trunk and #5714 causes it to time out 100% of the time due to the overhead of validation.
In this PR (https://github.com/gfx-rs/wgpu/actions/runs/10055037477/job/27791035441)
On trunk (https://github.com/gfx-rs/wgpu/actions/runs/10071973334/job/27843338838)
In #5714 (https://github.com/gfx-rs/wgpu/actions/runs/10071973334/job/27843338838) |
I'll play around with the numbers and lower it in #5714. |
Messed this up recently, was under the impression that this limits the iteration count only when running tests. Need to find another way to do that.
Still don't quite understand why that happens, I was fairly convinced that
cfg(test)
is not set for benchmarks inbenches
directory.