Remove latest_submission_index #5976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
approved these changes
Jul 18, 2024
teoxoy
approved these changes
Jul 18, 2024
|
@cwfitzgerald should we merge this now to get it in the release? Even more perf improvements for |
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this pull request
Sep 23, 2024
As of gfx-rs#5976, we no longer mark resources with the index of the latest queue submission at which they were used, so in `wgpu_core::Global::queue_submit`, rather than allocating a new submission index from `Device::active_submission_index` before processing all the command buffers, allocate it afterwards. This shrinks the criticial section between submission index allocation and actual submission, making gfx-rs#5978 easier to address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR flips how latest_submission_index is computed. Previously every submit told each resource that it was used. Now we run through the list of active submissions to see if any of them contain the buffer.
The act of incrementing the value for all resources was quite expensive for the few times we actually needed to know it.
Testing
Tests pass, wrote comments explaining my code
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.