Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wgpu-core] fix .zip() usages #5932

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[wgpu-core] fix .zip() usages #5932

merged 1 commit into from
Jul 10, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jul 10, 2024 •
edited
Loading

Fixes .zip() usages that were originally introduced in 4a19ac2 and d8b0b59 (part of #5897).

@teoxoy teoxoy requested a review from a team as a code owner July 10, 2024 10:15
nical
nical approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@nical nical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to use "skip" instead of "drop" since drop has a specific connotation in rust.

@teoxoy
Copy link
Member Author

teoxoy commented Jul 10, 2024

Talked with Nical and we settled on ZipWithProperAdvance.

@teoxoy teoxoy enabled auto-merge (rebase) July 10, 2024 14:31
@teoxoy teoxoy merged commit ef0ce05 into gfx-rs:trunk Jul 10, 2024
25 checks passed
@teoxoy teoxoy deleted the fix-zip-issues branch July 10, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nical nical nical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoxoy @nical