Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In readme, use emoji literals instead of shortcodes #5843

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

onkoe
Copy link
Contributor

@onkoe onkoe commented Jun 19, 2024

Good morning! Crates.io doesn't support emoji shortcodes like :ok:. While the readme's "supported platforms" listing looks great on GitHub, it's not so nice on Crates.io for that reason.

Such an issue can be moderately confusing for new users, and it's been bothering me for a while now.

Here's a minor fix to the readme that takes care of the problem! Please let me know if any changes are needed.

Otherwise, the emojis aren't parsed on Crates.io, leaving the table without much utility unless a user navigates to GitHub.

Fixes like these are very simple, but super helpful for some users! :)
@onkoe onkoe requested a review from a team as a code owner June 19, 2024 16:08
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, makes sense!

this is killing me though 😄
image

@Wumpf Wumpf enabled auto-merge (squash) June 19, 2024 17:52
@Wumpf Wumpf disabled auto-merge June 19, 2024 17:52
@Wumpf Wumpf enabled auto-merge (squash) June 19, 2024 17:53
@Wumpf Wumpf merged commit d4b3856 into gfx-rs:trunk Jun 19, 2024
25 checks passed
FL33TW00D pushed a commit to FL33TW00D/wgpu that referenced this pull request Jun 20, 2024
Otherwise, the emojis aren't parsed on Crates.io, leaving the table without much utility unless a user navigates to GitHub.

Fixes like these are very simple, but super helpful for some users! :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants