-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Improve resource and api logging. #5804
[core] Improve resource and api logging. #5804
Conversation
While you're here, maybe you feel like adding a cargo feature flag to remove logs statically? Iirc they have a fair amount of overhead just for checking if logging is enabled or not. |
9324267
to
90ef5be
Compare
Sorry, I can't - this was just a drive-by. |
tbh I doubt that the checks on the log flags are significant at all given all the other things that happen in those methods, but if this actually turns out to be a measurable overhead the macros/feature flags here can be expanded accordingly |
|
- Improve logging in `StatelessTracker::remove_abandoned` to show the outcome of the call. - Add similar logging to `BufferTracker` and `TextureTracker`. - Let `device_create_buffer`'s log only the new buffer's label, id, and whether it's mapped at creation. It used to show the whole descriptor, which is too much detail. - Have `queue_submit` log the submission id, and have `device_poll` log what it was waiting for, and what actually got done. - Have `Device::drop` log the destruction of the raw device when it actually happens, so it's properly ordered with respect to logging from other parts of the device, like `Device::command_allocator`.
90ef5be
to
4aa4b3b
Compare
Marked as draft, because this depends on #5802.
Improve logging in
StatelessTracker::remove_abandoned
to show theoutcome of the call.
Add similar logging to
BufferTracker
andTextureTracker
.Let
device_create_buffer
's log only the new buffer's label, id,and whether it's mapped at creation. It used to show the whole
descriptor, which is too much detail.
Have
queue_submit
log the submission id, and havedevice_poll
log what it was waiting for, and what actually got done.
Have
Device::drop
log the destruction of the raw device when itactually happens, so it's properly ordered with respect to logging
from other parts of the device, like
Device::command_allocator
.