Fix double decoration if a binding array contains a struct with a runtime array #5776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #5755
Description
Previously if a binding array contained a struct with a runtime array it would generate two
OpDecorate Block
s which was not allowed by the spirv specification.Testing
This shader no longer produces two
OpDecorate Block
sand a similar one inside naga's tests (binding-buffer-arrays.spvasm) also no longer produces two
OpDecorate Block
sChecklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
not applicable--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.